8000 [DT-190] Reveal all workflow ID by laurakwhit · Pull Request #981 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[DT-190] Reveal all workflow ID #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 9, 2022
Merged

[DT-190] Reveal all workflow ID #981

merged 8 commits into from
Dec 9, 2022

Conversation

laurakwhit
Copy link
Contributor
@laurakwhit laurakwhit commented Dec 7, 2022 •
edited
Loading

What was changed

Wraps Workflow ID instead of truncating it in the table on the Recent Workflow page so it is always visible.

Checklist

  1. Closes: DT-190

  2. How was this tested:

  • Verify workflow summary with filters is responsive
  • Verify workflow summary with filters and bulk actions is responsive
  • Verify workflow summary (without filters) is responsive
  1. Any docs updates needed? n/a

@vercel
Copy link
vercel bot commented Dec 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
holocene ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 5:20PM (UTC)
ui ✅ Ready (Inspect) Visit Preview Dec 9, 2022 at 5:20PM (UTC)

@cypress
Copy link
cypress bot commented Dec 7, 2022 •
edited
Loading


Test summary

90 • 0 • 0 • 0

Run details
Project Temporal UI
Status Passed
Commit 104288cfae ℹ️
Started Dec 9, 2022 5:21 PM
Ended Dec 9, 2022 5:27 PM
Duration 05:22 💡
OS Linux Ubuntu - 22.04
Browser Chrome 108

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@Alex-Tideman
Copy link
Contributor

Looks much better! Only thing I would suggest is giving the workflow ID column more width when the date fields are removed (i think md and lg break points, sm looks good).

Screen Shot 2022-12-08 at 8 09 24 AM

@Alex-Tideman
Copy link
Contributor

One more thing, we'll want more width on the 'Select all' column on sm.

Screen Shot 2022-12-08 at 8 16 06 AM

@Alex-Tideman
Copy link
Contributor

One last final thing, I think we still want the awesome gradient for the row on hover.

@laurakwhit laurakwhit force-pushed the DT-190-reveal-all-workflowID branch from 43840ba to d6f4413 Compare December 9, 2022 00:06
@laurakwhit laurakwhit merged commit 6079d46 into main Dec 9, 2022
@laurakwhit laurakwhit deleted the DT-190-reveal-all-workflowID branch December 9, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Tideman Alex-Tideman Alex-Tideman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurakwhit @Alex-Tideman
0