forward props for Accordion #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also make it expandable via keyboard - move accordion and accordion story into its own folder
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
This comment was marked as outdated.
This comment was marked as outdated.
laurakwhit
reviewed
Dec 7, 2022
| <button | ||
| id="{id}-trigger" | ||
| aria-expanded={open} | ||
| aria-controls="{id}-content" |
There was a problem hiding this comment.
We could use title here instead, but there is the risk that it won't be unique. We might want to think about creating a generic util to generate a unique id for use cases such as this.
Suggested change
| aria-controls="{id}-content" | |
| aria-controls="{title}-content" |
Another approach could be to rework this to be a <li> inside of a <ul> and use the index + title for the id.
Ultimately, I think aria-expanded is the most important addition here 😅
use uuid for default value add types for uuid and upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Implement type-safe prop forwarding for
<Accordion />Why?
Checklist
Closes
How was this tested: