8000 Improve ux of compact view left side links by laurakwhit · Pull Request #969 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve ux of compact view left side links #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 2, 2022
Merged

Improve ux of compact view left side links #969

merged 8 commits into from
Dec 2, 2022

Conversation

laurakwhit
Copy link
Contributor
@laurakwhit laurakwhit commented Dec 2, 2022 •
edited
Loading

What was changed

In the Compact view

  • Removes first line of event data
  • Updates active and hover for rows
  • Updates styling on the list of event groups
  • Updates selected pill color in event group details
  • Updates badge color on event group details
  • Sets default event in event group to most recent event and shows events in descending order
Before After
Screenshot 2022-12-01 at 5 35 44 PM Screenshot 2022-12-01 at 5 34 07 PM
before-expanded after-expanded

Checklist

  1. Closes: DT-60 and DT-57

  2. How was this tested:

  • Verify event History and Compact view tables still work as expected
  • Verify Event Type is truncated correctly
    • in the History view
    • in the Compact view
    • In the Compact view with either a failure, termination, or cancelation
  • Verify default group event for a row in the Compact view is the most recent event
  • Verify active state is correct for
    • a selected row
    • a selected event group in event details
    • a selected nav pill in event details
  • Verify responsiveness with an event row expanded
  1. Any docs updates needed? n/a

@vercel
Copy link
vercel bot commented Dec 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
holocene ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 5:14PM (UTC)
ui ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 5:14PM (UTC)

@cypress
Copy link
cypress bot commented Dec 2, 2022 •
edited
Loading


Test summary

88 • 0 • 0 • 0

Run details
Project Temporal UI
Status Passed
Commit a1baae87c7 ℹ️
Started Dec 2, 2022 5:14 PM
Ended Dec 2, 2022 5:19 PM
Duration 05:13 💡
OS Linux Ubuntu - 20.04
Browser Chrome 107

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@laurakwhit laurakwhit changed the title [DT-60] Improve ux of compact view left side links Improve ux of compact view left side links Dec 2, 2022
@laurakwhit laurakwhit merged commit cd9d776 into main Dec 2, 2022
@laurakwhit laurakwhit deleted the DT-60-Improve-UX-of-compact-view-left-side-links branch December 2, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Tideman Alex-Tideman Alex-Tideman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurakwhit @Alex-Tideman
0