8000 [DT-149] Fix for invite user issue with email addition auto scrolling by laurakwhit · Pull Request #956 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[DT-149] Fix for invite user issue with email addition auto scrolling #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 28, 2022
Merged

[DT-149] Fix for invite user issue with email addition auto scrolling #956

merged 8 commits into from
Nov 28, 2022

Conversation

laurakwhit
Copy link
Contributor

What was changed

  • Adds auto scroll so on the input (and cursor) is visible after chips are added or the input is selected.
  • Capitalizes "N" for Namespace on the Namespace switcher and elsewhere
Tooltip Switcher Welcome page
Screen Shot 2022-11-21 at 2 13 26 PM Screen Shot 2022-11-21 at 2 13 39 PM Screen Shot 2022-11-21 at 2 14 58 PM
  • Capitalizes "N" for Namespace on the Namespace switcher

Checklist

  1. Closes: DT-149 and DT-151

  2. How was this tested:

  • Verify that after typing out multiple tags (past the min height), and another tag, is added that the container scrolls and the input and cursor are visible
  • Verify after pasting multiple tags (past the min height) that the container scrolls and the input and cursor are visible
  • Verify scrolling up and removing a tag via x that the container does not scroll
  • Verify if there are multiple tags (past the min height) and the input is selected, the container scrolls and the input and cursor are visible
  • Verify input still works as expected
  • Verify Namespace is capitalized on the Namespace switcher
  • Verify Namespace is capitalized on the welcome page
  1. Any docs updates needed? n/a

@vercel
Copy link
vercel bot commented Nov 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
holocene ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 5:03PM (UTC)
ui ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 5:03PM (UTC)

@cypress
Copy link
cypress bot commented Nov 21, 2022 •
edited
Loading


Test summary

76 • 0 • 12 • 0

Run details
Project Temporal UI
Status Passed
Commit 70a2164427 ℹ️
Started Nov 22, 2022 5:03 PM
Ended Nov 22, 2022 5:07 PM
Duration 04:14 💡
OS Linux Ubuntu - 20.04
Browser Chrome 107

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

rossedfort
rossedfort reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor
@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small suggestions, but looks good otherwise!
rossedfort
rossedfort reviewed Nov 21, 2022
View reviewed changes
src/lib/holocene/input/chip-input.svelte
@@ -10,13 +12,39 @@
export let required = false;
export let hintText = '';
export let validator: (value: string) => boolean = () => true;
const values = writable<string[]>(chips);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation behind making this a store?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted some way to compare the previous values to the new values to determine if shouldScrollToInput after the input updates. Open to ideas if there's a better way to go about this!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that makes sense. This is good I was just curious 🙂

rossedfort
rossedfort reviewed Nov 22, 2022
View reviewed changes
@laurakwhit laurakwhit force-pushed the DT-149-invite-user-issue-with-email-addition-auto-scrolling branch from a6fd8da to 9dfc654 Compare November 22, 2022 17:02
@laurakwhit laurakwhit merged commit 313a57b into main Nov 28, 2022
@laurakwhit laurakwhit deleted the DT-149-invite-user-issue-with-email-addition-auto-scrolling branch November 28, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossedfort rossedfort rossedfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurakwhit @rossedfort
0