8000 Implement bulk terminate by rossedfort · Pull Request #912 · temporalio/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement bulk terminate #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Nov 8, 2022
Merged

Implement bulk terminate #912

merged 24 commits into from
Nov 8, 2022

Conversation

rossedfort
Copy link
Contributor
@rossedfort rossedfort commented Oct 31, 2022 •
edited
Loading

What was changed

Add support for bulk/batch terminating workflows via the UI

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@vercel
Copy link
vercel bot commented Oct 31, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
holocene ✅ Ready (Inspect) Visit Preview Nov 8, 2022 at 5:34PM (UTC)
ui ✅ Ready (Inspect) Visit Preview Nov 8, 2022 at 5:34PM (UTC)

@rossedfort
revert delete workflows-summary-table
6a33cfb 
fix workflows-summary-row
@cypress
Copy link
cypress bot commented Oct 31, 2022 •
edited
Loading


Test summary

70 • 0 • 12 • 0

Run details
Project Temporal UI
Status Passed
Commit c7a480c177 ℹ️
Started Nov 8, 2022 5:35 PM
Ended Nov 8, 2022 5:40 PM
Duration 05:06 💡
OS Linux Ubuntu - 20.04
Browser Chrome 107

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@rossedfort rossedfort changed the title WIP - bulk terminate Implement bulk terminate Oct 31, 2022
@rossedfort rossedfort marked this pull request as ready for review October 31, 2022 20:19
rossedfort
rossedfort commented Oct 31, 2022
View reviewed changes
@rossedfort
poll for termination operation
b341213 
add success/error toasts
change workflow "continued as new" badge copy
add confirmation modal
@rossedfort
small bulk terminate design changes
eb5239a 
- use default danger color for bulk action button
- add height to table headers so they don't grow/shrink
- pluralize copy in modal
rossedfort
rossedfort commented Nov 3, 2022
View reviewed changes
@rossedfort
disable bulk actions for now
f061cf4 
add disabled state to bulk action button
@rossedfort rossedfort merged commit 65430f6 into main Nov 8, 2022
@rossedfort rossedfort deleted the bulk-terminate branch November 8, 2022 18:11
@rossedfort rossedfort mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekinney stevekinney stevekinney approved these changes

@Alex-Tideman Alex-Tideman Alex-Tideman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rossedfort @stevekinney @Alex-Tideman
0