Verify cluster name in remove cluster call #3715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
8000
reviewed
Dec 15, 2022
service/frontend/operator_handler.go
Outdated
| } | ||
| } | ||
| if !isClusterNameExist { | ||
| return nil, serviceerror.NewInvalidArgument("The cluster to be deleted cannot be found in clusters cache.") |
There was a problem hiding this comment.
Good catch. Updated to not found error.
yycptt
approved these changes
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Verify cluster name in remove cluster call.
Why?
The remove response should return an error if the cluster name is invalid instead of return a success.
How did you test it?
Potential risks
Is hotfix candidate?