Improve execution scavenger #3674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Nov 29, 2022
| @@ -167,6 +181,11 @@ func (t *task) validate( | |||
| results = append(results, validationResults...) | |||
| } | |||
|
|
|||
| // Fail fast if the mutable is corrupted, no need to validate history. | |||
| if len(results) > 0 { | |||
There was a problem hiding this comment.
shall we change the mutableStateValidator.Validate() logic to check retention first and if it exceeds retention it should not do any further checking. Also we should enable delete when it detect closed executions exceeds retention.
There was a problem hiding this comment.
Yes. Currently, it will delete if expired data detected.
There was a problem hiding this comment.
Update to return if the retention check fails.
yiminc
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?
No