8000 Fix typo in dynamic config for VisibilityProcessorEnsureCloseBeforeDelete by MichaelSnowden · Pull Request #3632 · temporalio/temporal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix typo in dynamic config for VisibilityProcessorEnsureCloseBeforeDelete #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

MichaelSnowden
Copy link
Contributor

What changed?
I changed the value of VisibilityProcessorEnsureCloseBeforeDelete from history.transferProcessorEnsureCloseBeforeDelete to history.visibilityProcessorEnsureCloseBeforeDelete.

Why?
I made this change because the original key used was a typo.

How did you test it?
Code search.

Potential risks
Anyone that disabled history.transferProcessorEnsureCloseBeforeDelete in order to disable the VisibilityProcessorEnsureCloseBeforeDelete behavior, will now see it reset to true.

Is hotfix candidate?
No.

@MichaelSnowden MichaelSnowden requested a review from a team as a code owner November 21, 2022 17:23
@yiminc yiminc merged commit 86631e9 into master Nov 21, 2022
@yiminc yiminc deleted the close-before-delete branch November 21, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0