8000 Keep multi cursor default reader always running by yycptt · Pull Request #3626 · temporalio/temporal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Keep multi cursor default reader always running #3626

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2022
Merged

Keep multi cursor default reader always running #3626

merged 1 commit into from
Nov 19, 2022

Conversation

yycptt
Copy link
Member
@yycptt yycptt commented Nov 19, 2022

What changed?

  • Keep multi cursor default reader always running

Why?

  • otherwise when traffic is low, default reader will keep start/stop and generate lots of log message for starting/stopping which pollutes the log.

How did you test it?

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from a team as a code owner November 19, 2022 00:30
@yycptt yycptt merged commit 9541374 into temporalio:master Nov 19, 2022
@yycptt yycptt deleted the keep-default-reader-running branch November 19, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @yux0 @yiminc
0