Handle unknown cluster during replication #3619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
reviewed
Nov 18, 2022
rodrigozhou
approved these changes
Nov 18, 2022
yycptt
reviewed
Nov 18, 2022
There was a problem hiding this comment.
Basically we ignore unknown cluster during replication and still apply the task? Will this case any issue after the cluster that applied the replication task later come active. I mean, I know there will be errors, but I don't see how we can recover from that error other than connect those two clusters.
yycptt
reviewed
Nov 18, 2022
| sourceCluster := clusterMetadata.ClusterNameForFailoverVersion(true, version) | ||
| sourceCluster, err := clusterMetadata.ClusterNameForFailoverVersion(true, version) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
This will fail the entire get replication task call or just drop this replication task?
There was a problem hiding this comment.
It will fail the apply replication task call and the replication stack will put this task into DLQ after some retries.
yycptt
approved these changes
Nov 18, 2022
meiliang86
pushed a commit
that referenced
this pull request
Nov 22, 2022
* Handle unknown cluster during replication
meiliang86
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Handle unknown cluster during replication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Handle unknown cluster during replication
Why?
When replicate a workflow from cluster B to cluster C, we don't know if the workflow has any history events generate from a different cluster (e.g. cluster A). In this case, currently we can blindly apply this task rather than panic.
How did you test it?
Local test
Potential risks
Is hotfix candidate?
No