8000 Enforce the pending cancel request limit by MichaelSnowden · Pull Request #3615 · temporalio/temporal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enforce the pending cancel request limit #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 19, 2022
Merged

Enforce the pending cancel request limit #3615

merged 4 commits into from
Nov 19, 2022

Conversation

MichaelSnowden
Copy link
Contributor

What changed?
We now fail any command batch that would leave us with too many pending cancel requests.

Why?
To enforce workflow size constraints.

How did you test it?
I added a large integration test that verifies that a workflow that tries to cancel them all at once fails, but that a workflow that attempts to cancel them in batches no greater than the maximum number of pending cancel requests.

Potential risks
This will likely break any workflows that attempt to cancel a large number of workflows, from within a workflow in rapid succession.

Is hotfix candidate?
Requires a notification to the community.

@MichaelSnowden MichaelSnowden requested a review from a team as a code owner November 17, 2022 21:48
@MichaelSnowden MichaelSnowden force-pushed the ms-limits/enforce-wf-size-limits branch from 7de06f2 to a82c3ac Compare November 18, 2022 21:26
Base automatically changed from ms-limits/enforce-wf-size-limits to master November 18, 2022 21:55
@MichaelSnowden MichaelSnowden force-pushed the ms-limits/cancel-requests branch from eb4caed to 3f185f3 Compare November 18, 2022 22:00
@MichaelSnowden MichaelSnowden enabled auto-merge (squash) November 18, 2022 22:02
@MichaelSnowden MichaelSnowden force-pushed the ms-limits/cancel-requests branch from 3f185f3 to 08d65fb Compare November 18, 2022 22:40
@MichaelSnowden MichaelSnowden force-pushed the ms-limits/cancel-requests branch from 08d65fb to f156424 Compare November 18, 2022 23:51
@MichaelSnowden MichaelSnowden merged commit df160db into master Nov 19, 2022
@MichaelSnowden MichaelSnowden deleted the ms-limits/cancel-requests branch November 19, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelSnowden @yux0
0