Move queue metrics to metrics package #3587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Nov 14, 2022
Comment on lines
-48
to
-56
| TaskLoadLatency = "task_latency_load" // latency from task generation to task loading (persistence scheduleToStart) | ||
| TaskScheduleLatency = "task_latency_schedule" // latency from task submission to in-memory queue to processing (in-memory scheduleToStart) | ||
| TaskProcessingLatency = "task_latency_processing" // latency for processing task one time | ||
| TaskNoUserProcessingLatency = "task_latency_processing_nouserlatency" // same as TaskProcessingLatency, but excludes workflow lock latency | ||
| TaskLatency = "task_latency" // task in-memory latency across multiple attempts | ||
| TaskNoUserLatency = "task_latency_nouserlatency" // same as TaskLatency, but excludes workflow lock latency | ||
| TaskQueueLatency = "task_latency_queue" // task e2e latency | ||
| TaskNoUserQueueLatency = "task_latency_queue_nouserlatency" // same as TaskQueueLatency, but excludes workflow lock latency | ||
| TaskUserLatency = "task_latency_userlatency" // workflow lock latency across multiple attempts |
There was a problem hiding this comment.
Please make sure those comments are copied to metrics package as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Move queue metrics to metrics package
Why?
Have all metrics tag and scope in metrics package.
How did you test it?
Potential risks
Is hotfix candidate?
No