Make shard more resilient to append history timeout #3564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Nov 7, 2022
| @@ -113,6 +113,11 @@ type ( | |||
| Msg string | |||
| } | |||
|
|
|||
| // AppendHistoryError represents a failed insert to history tree / node request | |||
| AppendHistoryError struct { | |||
| Msg string | |||
There was a problem hiding this comment.
AppendHistoryTimeoutError maybe?
Please also update the logic in persistence metrics client (the switch case).
yycptt
approved these changes
Nov 7, 2022
wxing1292
added a commit
that referenced
this pull request
Nov 8, 2022
* Make shard more resilient to append history timeout by not triggering shard ownership check
yux0
pushed a commit
to yux0/temporal
that referenced
this pull request
Nov 8, 2022
* Make shard more resilient to append history timeout by not triggering shard ownership check
nagl-temporal
pushed a commit
that referenced
this pull request
Nov 9, 2022
* Make shard more resilient to append history timeout by not triggering shard ownership check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
See above
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
N/A