Add a new archiver client which doesn't retry #3544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e7fff8 to
e7655f0
Compare
yux0
reviewed
Oct 31, 2022
e7655f0 to
1578ef2
Compare
yux0
reviewed
Nov 1, 2022
df67b99 to
91114e6
Compare
yux0
reviewed
Nov 1, 2022
yux0
reviewed
Nov 1, 2022
yux0
approved these changes
Nov 1, 2022
91114e6 to
93f26b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I added a new archival tool which doesn't rely on the archival workflow.
Why?
I made this change so that we can deprecate the archival workflow and move to the archival queue.
How did you test it?
I tested this change by adding unit tests which verify the side-effects, metrics, logs and return errors for the archiver with different input targets and errors.
Potential risks
Nothing--it's not used in production.
Is hotfix candidate?
No