8000 Fix replication task nil case by yux0 · Pull Request #3531 · temporalio/temporal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix replication task nil case #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2022
Merged

Fix replication task nil case #3531

merged 3 commits into from
Oct 26, 2022

Conversation

yux0
Copy link
Contributor
@yux0 yux0 commented Oct 24, 2022

What changed?
Fix replication task nil case

Why?

  1. Handle if the replication task is nil, we don't need to handle new run case.
  2. We should generate replication task even if the workflow is closed.

How did you test it?

Potential risks

Is hotfix candidate?

@yux0 yux0 requested a review from yycptt October 8000 24, 2022 21:21
@yux0 yux0 requested a review from a team as a code owner October 24, 2022 21:21
mindaugasrukas
mindaugasrukas approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor
@mindaugasrukas mindaugasrukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yux0 yux0 merged commit 275b62b into temporalio:master Oct 26, 2022
@yux0 yux0 deleted the replication-panic branch October 26, 2022 21:50
dnr pushed a commit that referenced this pull request Oct 31, 2022
@yux0 @dnr
Fix replication task nil case (#3531)
c6cfe6d 
* Fix replication task nil case
wxing1292 pushed a commit that referenced this pull request Nov 8, 2022
@yux0 @wxing1292
Fix replication task nil case (#3531)
ebce4d3 
* Fix replication task nil case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mindaugasrukas mindaugasrukas mindaugasrukas approved these changes

@yycptt yycptt Awaiting requested review from yycptt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yux0 @mindaugasrukas @dnr
0