8000 Clean up task latency metrics by yycptt · Pull Request #3510 · temporalio/temporal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clean up task latency metrics #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 16, 2022
Merged

Clean up task latency metrics #3510

merged 4 commits into from
Nov 16, 2022

Conversation

yycptt
Copy link
Member
@yycptt yycptt commented Oct 18, 2022 •
edited
Loading

What changed?

  • Clean up metrics in task_latency family to reduce load on metrics server.
  • The following five will be emitted
	TaskLoadLatency                 = "task_latency_load"       // latency from task generation to task loading (persistence scheduleToStart)
	TaskScheduleLatency             = "task_latency_schedule"   // latency from task submission to in-memory queue to processing (in-memory scheduleToStart)
	TaskProcessingLatency           = "task_latency_processing" // latency for processing task one time
	TaskProcessingUserLatency       = "task_latency_user"       // latency for locking workflow execution
        TaskLatency                     = "task_latency"            // in-memory latency
	TaskQueueLatency                = "task_latency_queue"      // task e2e latency

Why?

How did you test it?

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from yiminc October 18, 2022 23:22
@yycptt yycptt requested a review from a team as a code owner October 18, 2022 23:22
yycptt
yycptt commented Nov 16, 2022
View reviewed changes
common/metrics/metric_defs.go
TaskProcessingUserLatency = NewTimerDef("task_latency_user") // latency for locking workflow execution
TaskLatency = NewTimerDef("task_latency") // task in-memory latency across multiple attempts
TaskQueueLatency = NewTimerDef("task_latency_queue") // task e2e latency
TaskAttempt = NewDimensionlessHistogramDef("task_attempt")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yux0 Fixed task attempt metrics here.

@yycptt yycptt enabled auto-merge (squash) November 16, 2022 06:55
@yycptt yycptt merged commit 02b913f into temporalio:master Nov 16, 2022
@yycptt yycptt deleted the clean-up-task-latency-metrics branch November 16, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @yux0 @yiminc
0