Create visibility GetWorkflowExecution API #3488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Oct 15, 2022
common/persistence/visibility/store/standard/sql/visibility_store.go
Outdated
Show resolved
Hide resolved
alexshtin
reviewed
Oct 17, 2022
alexshtin
approved these changes
Oct 17, 2022
ae4be9a to
d8ca769
Compare
d8ca769 to
34361c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Creating visibility API to get a single workflow execution by run id.
Why?
This will be used to get search attributes and memo from visibility for closed workflows.
How did you test it?
Unit tests.
Potential risks
In SQL template query to get closed workflow by run id, I removed the filter to exclude running workflows. It means that, with this change, the query will return a record if the workflow is found by run id, but its status is running. I'm not sure where this specific query is used though.
Is hotfix candidate?
No.