8000 Compare task type enum by yux0 · Pull Request #3464 · temporalio/temporal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Compare task type enum #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2022
Merged

Compare task type enum #3464

merged 3 commits into from
Oct 10, 2022

Conversation

yux0
Copy link
Contributor
@yux0 yux0 commented Oct 10, 2022

What changed?
Compare task type enum

Why?
No need to convert to string and compare

How did you test it?

Potential risks

Is hotfix candidate?

@yux0 yux0 requested a review from dnr October 10, 2022 18:09
@yux0 yux0 requested a review from a team as a code owner October 10, 2022 18:09
dnr
dnr approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member
@dnr dnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Sorry the parsing part is more verbose but I think it's worth it for less runtime overhead

@yux0 yux0 merged commit bc451db into temporalio:master Oct 10, 2022
dnr pushed a commit that referenced this pull request Oct 10, 2022
@yux0 @dnr
Compare task type enum (#3464)
6EC3
cb2f574 
* Compare task type enum
@yux0 yux0 deleted the task-type branch October 10, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnr dnr dnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yux0 @dnr
0