Ensure urfave/cli accepts flag values with comma #3440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
612c387 to
7c41f86
Compare
7c41f86 to
ca0390d
Compare
alexshtin
approved these changes
Sep 29, 2022
ca0390d to
3d13f77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Set urfave/cli to v2.4.0
test for verifying it processes flag values with comma (thx @dnr )
Also sending a PR into urfave/cli to allow configuring the separator
Why?
The values for inputs, search attributes etc may contain comma
How did you test it?
unit test
Potential risks
Is hotfix candidate?