Propagate CloseVisibilityTaskId to DeleteExecutionVisibilityTask #3404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Sep 20, 2022
| @@ -970,6 +970,7 @@ func (s *ContextImpl) DeleteWorkflowExecution( | |||
| branchToken []byte, | |||
| startTime *time.Time, | |||
| closeTime *time.Time, | |||
| closeVisibilityTaskId int64, | |||
There was a problem hiding this comment.
or maybe closeExecutionVisibilityTaskID to be consistent with the task type name defined here: https://github.com/temporalio/temporal/blob/master/service/history/tasks/close_visibility_task.go#L37
There was a problem hiding this comment.
Fixed, thanks for catching that!
yycptt
approved these changes
Sep 20, 2022
| @@ -970,6 +970,7 @@ func (s *ContextImpl) DeleteWorkflowExecution( | |||
| branchToken []byte, | |||
| startTime *time.Time, | |||
| closeTime *time.Time, | |||
| closeVisibilityTaskId int64, | |||
There was a problem hiding this comment.
or maybe closeExecutionVisibilityTaskID to be consistent with the task type name defined here: https://github.com/temporalio/temporal/blob/master/service/history/tasks/close_visibility_task.go#L37
1893e72 to
c4bd3c2
Compare
c4bd3c2 to
183ef90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagates the CloseVisibilityTaskId to the DeleteExecutionVisibilityTask, so that we can wait on the close visibility task to complete before we delete the execution visibility.