Measure backlog after completing current task #4562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
PollWorkflowTaskQueue returns a hint for the backlog on the task queue polled, which is measured (approximately) as tasks in the taskReader buffer or pending return to a poller. When matching a task that came from the db, the task itself would be counted in the backlog, since the backlog was recorded at match time, instead of after marking the task acked.
This measures the backlog after marking the task acked.
Why?
SDKs always poll on the sticky queue if there is a backlog, so they could incorrectly poll on the sticky queue when there are no tasks there and neglect the normal queue, causing a delay of up to the long poll interval.
How did you test it?
manually for now
Potential risks
Is hotfix candidate?