Add corruption protection to ms #4560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Jun 29, 2023
yycptt
approved these changes
Jun 29, 2023
| tag.WorkflowRunID(ms.executionState.RunId), | ||
| tag.Value(ms.hBuilder), | ||
| ) | ||
| return false, serviceerror.NewInternal("MutableState encountered dirty transaction") |
There was a problem hiding this comment.
should we return an retryable error?
There was a problem hiding this comment.
this logic should return internal since the sanity check failed. however, if the internal error will not be retried then the error type should be changed, what do you suggest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
N/A
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
N/A