Get execution start/close time when using cassandra visibility store #4549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a342ea0 to
f264a67
Compare
rodrigozhou
commented
Jun 28, 2023
Comment on lines
212
to
+214
| var startTime *time.Time | ||
| var closeTime *time.Time | ||
| // There are cases when workflow execution is closed but visibility is not updated and still open. | ||
| // This happens, for example, when workflow execution is deleted right from CloseExecutionTask. | ||
| // Therefore, force to delete from open visibility regardless of execution state. | ||
| if forceDeleteFromOpenVisibility || ms.GetExecutionState().State != enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED { | ||
| startTime = ms.GetExecutionInfo().GetStartTime() | ||
| } else { | ||
| closeTime, err = ms.GetWorkflowCloseTime(ctx) | ||
| if err != nil { | ||
| return err | ||
| if m.visibilityManager.HasStoreName(cassandra.CassandraPersistenceName) { |
There was a problem hiding this comment.
When these values are nil, the visibility task will fail (panic) only when using Cassandra.
yycptt
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Check if it's using Cassandra visibility store before getting execution start/close time.
Why?
Start/close time is only needed for deletion if it's using Cassandra as visibility store.
How did you test it?
Unit test.
Potential risks
No.
Is hotfix candidate?
No.