8000 Add Support for Tekton Pipeline v1 APIs by khrm · Pull Request #762 · tektoncd/results · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Support for Tekton Pipeline v1 APIs #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Conversation

khrm
Copy link
Contributor
@khrm khrm commented Jun 18, 2024

Changes

Add support for storing PipelineRun and TaskRun objects as v1.
These CRs are reconciled as the v1 version of Pipelines API and then
stored in DB as v1. Existing v1beta1 resources are kept as it is.
An ability to convert these older records to v1 will be added.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Records of TaskRuns and PipelineRuns are as stored as v1 in db instead of v1beta1.
Add support for storing PipelineRun and TaskRun objects as v1.
These CRs are reconciled as the v1 version of Pipelines API and then
stored in DB as v1. Existing v1beta1 resources are kept as it is.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 18, 2024
Copy link
Contributor Author
@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 18, 2024
@tekton-robot tekton-robot requested review from avinal and enarha June 18, 2024 10:30
@khrm
Copy link
Contributor Author
khrm commented Jun 18, 2024

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2024
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%< 8000 /td>
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%

@khrm
Copy link
Contributor Author
khrm commented Jun 18, 2024

/test pull-tekton-results-build-tests

@khrm
Copy link
Contributor Author
khrm commented Jun 18, 2024

/test pull-tekton-results-unit-tests

@khrm
Copy link
Contributor Author
khrm commented Jun 18, 2024

/test pull-tekton-results-integration-tests

@khrm
Copy link
Contributor Author
khrm commented Jun 18, 2024

/test pull-tekton-results-build-tests

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%

@khrm
Copy link
Contributor Author
khrm commented Jun 18, 2024

/test pull-tekton-results-build-tests

@tekton-robot
Copy link
8000

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%

@khrm
Copy link
Contributor Author
khrm commented Jun 18, 2024

/test pull-tekton-results-build-tests

@khrm
Copy link
Contributor Author
khrm commented Jun 18, 2024

/test pull-tekton-results-build-tests

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/api/server/v1alpha2/log/s3.go 38.2% 0.0% -38.2
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%

@khrm
Copy link
Contributor Author
khrm commented Jun 18, 2024

/test pull-tekton-results-build-tests

@khrm khrm force-pushed the results2v1 branch 2 times, most recently from d8b2903 to 34f2e68 Compare July 15, 2024 11:56
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2024
@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/test pull-tekton-results-unit-tests

@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/test pull-tekton-results-integration-tests

@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/test pull-tekton-results-build-tests

@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/test pull-tekton-results-go-coverage

@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/test pull-tekton-results-unit-tests

@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/test pull-tekton-results-integration-tests

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 0.0%
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%

@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/retest

khrm added 3 commits July 15, 2024 17:38
Add support for storing PipelineRun and TaskRun objects as v1.
These CR are reconciled as v1 version of Pipelines API and then
stored in DB as v1. Existing v1beta1 resources are kept as it is.
An ability to convert these older record to v1 will be added.
@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/retest

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 0.0%
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%

@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/retest

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/test/clients.go Do not exist 83.3%
pkg/internal/test/clients.go Do not exist 0.0%
pkg/internal/test/clients.go Do not exist 83.3%
pkg/watcher/reconciler/pipelinerun/reconciler.go 45.3% 41.9% -3.4
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%
proto/v1alpha2/results_go_proto/api.pb.gw.go Do not exist 0.0%

@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/test pull-tekton-results-unit-tests

2 similar comments
@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/test pull-tekton-results-unit-tests

@khrm
Copy link
Contributor Author
khrm commented Jul 15, 2024

/test pull-tekton-results-unit-tests

@enarha
Copy link
Contributor
enarha commented Jul 15, 2024

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
@tekton-robot tekton-robot merged commit 1629f9a into tektoncd:main Jul 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0