tedious · tedivm · Mar 21, 2022 · Dec 21, 2016 · Feb 26, 2022 · Feb 26, 2022
diff --git a/.github/workflows/pr_tests.yml b/.github/workflows/pr_tests.yml
@@ -1,6 +1,6 @@
 name: CI
 
-on: [push]
+on: [push, pull_request]
 env:
   IS_GITHUB: "true"
 

diff --git a/src/Stash/Interfaces/PoolInterface.php b/src/Stash/Interfaces/PoolInterface.php
@@ -131,6 +131,17 @@ public function getNamespace();
      */
     public function setLogger($logger);
 
+    /**
+     * Sets the default cache invalidation method for items created by this pool object.
+     *
+     * @see Stash\Invalidation
+     *
+     * @param int   $invalidation A Stash\Invalidation constant
+     * @param mixed $arg          First argument for invalidation method
+     * @param mixed $arg2         Second argument for invalidation method
+     */
+    public function setInvalidationMethod($invalidation, $arg = null, $arg2 = null);
+
     /**
     * Forces any save-deferred objects to get flushed to the backend drivers.
     *

diff --git a/src/Stash/Pool.php b/src/Stash/Pool.php
@@ -63,6 +63,27 @@ class Pool implements PoolInterface
      */
     protected $namespace;
 
+    /**
+     * The default cache invalidation method for items created by this pool object.
+     *
+     * @var int
+     */
+    protected $invalidationMethod = Invalidation::PRECOMPUTE;
+
+    /**
+     * Argument 1 for the default cache invalidation method
+     *
+     * @var mixed
+     */
+    protected $invalidationArg1 = null;
+
+    /**
+     * Argument 2 for the default cache invalidation method
+     *
+     * @var mixed
+     */
+    protected $invalidationArg2 = null;
+
     /**
      * The constructor takes a Driver class which is used for persistent
      * storage. If no driver is provided then the Ephemeral driver is used by
@@ -120,6 +141,7 @@ public function getItem($key)
         $item = new $this->itemClass();
         $item->setPool($this);
         $item->setKey($key, $namespace);
+        $item->setInvalidationMethod($this->invalidationMethod, $this->invalidationArg1, $this->invalidationArg2);
 
         if ($this->isDisabled) {
             $item->disable();
@@ -308,6 +330,18 @@ public function setLogger($logger)
         return true;
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function setInvalidationMethod($invalidation = Invalidation::PRECOMPUTE, $arg = null, $arg2 = null)
+    {
+        $this->invalidationMethod = $invalidation;
+        $this->invalidationArg1 = $arg;
+        $this->invalidationArg2 = $arg2;
+
+        return true;
+    }
+
     /**
      * Logs an exception with the Logger class, if it exists.
      *

diff --git a/tests/Stash/Test/AbstractPoolTest.php b/tests/Stash/Test/AbstractPoolTest.php
@@ -12,6 +12,7 @@
 namespace Stash\Test;
 
 use Stash\Exception\InvalidArgumentException;
+use Stash\Invalidation;
 use Stash\Pool;
 use Stash\Driver\Ephemeral;
 use Stash\Test\Stubs\LoggerStub;
@@ -348,6 +349,18 @@ public function testLoggerPurge()
         $this->assertEquals('critical', $logger->lastLevel, 'Exceptions logged as critical.');
     }
 
+    public function testSetInvalidationMethod()
+    {
+        $pool = $this->getTestPool();
+
+        $pool->setInvalidationMethod(Invalidation::OLD, 'test1', 'test2');
+        $item = $pool->getItem('test/item');
+
+        $this->assertAttributeEquals(Invalidation::OLD, 'invalidationMethod', $item, 'Pool sets Item invalidation constant.');
+        $this->assertAttributeEquals('test1', 'invalidationArg1', $item, 'Pool sets Item invalidation argument 1.');
+        $this->assertAttributeEquals('test2', 'invalidationArg2', $item, 'Pool sets Item invalidation argument 2.');
+    }
+
     /**
      * @return \Stash\Pool
      */

diff --git a/tests/Stash/Test/Stubs/PoolGetDriverStub.php b/tests/Stash/Test/Stubs/PoolGetDriverStub.php
@@ -74,6 +74,11 @@ public function setLogger($logger)
         return false;
     }
 
+    public function setInvalidationMethod($invalidation, $arg = null, $arg2 = null)
+    {
+        return false;
+    }
+
     public function hasItem($key)
     {
         return false;