Fix clippy warnings #188
Fix clippy warnings #188
Conversation
- allow struct excessive bools for Args struct.
- change tests to use write_all instead of write
- allow dead_code for the ConvigVar variant of PathSource
- allow struct excessive bools for Args struct. - change tests to use write_all instead of write - allow dead_code for the ConvigVar variant of PathSource
|
@niklasmohrin review please :) this just fixes I wasn't sure if there was a reason for the ConfgVar variant in the Edit: annoyingly the CI clippy check doesn't like the |
There was a problem hiding this comment.
@dmaahs2017 the problem with the "excessive bools" lint is that the clippy version in CI does not know that lint yet. Right now we're testing with 1.51.0. Feel free to update that version in the CI config for the clippy job to the latest stable (1.52.0)!
There was a problem hiding this comment.
Can only agree with @dbrgn, comment seems like a good idea and feel free to bump the rust version in .github/workflows/ci.yaml. Other than that, there's nothing to complain about. Good catch with write_all!
@dbrgn Why do we have MSRV anyway? It's not like we're a library that people depend on, so does it even matter? We could just say "builds on stable, everything else no guarantees"
I'm curious why we run our tests on 1.41.1 as well as on stable |
eb8795f to
b9fcc6f
Compare
|
@dmaahs2017 FYI, further steps with MSRV are currently discussed in #190 |