Add getStore helper + withStore HoC. Change callback + remove Store + add docs + add tests #19
Conversation
|
Hi, I am Siddharth and I'd like to mention that this is a great library, it is very simple, straightforward and easy to use. Awesome work 👏 I am using it for my university course project and I was looking for something exactly like getStore. I wanted to know if you have an ETA on how long before this PR will be merged? Thank you. |
|
@siddharthborderwala Thanks a lot! It will take me a while to document and test everything well and maybe some fix / improvement, maybe 1 or 2 days. But since you show interest I have made a prerelease with this in: In theory, everything should work fine, but if you encounter any problem you can comment on it here 🙏 😊 It has some breaking changes that need to be better documented. As we are in an early |
|
Okay, I hear you. Thank you for your time, what I did is use the index.js file inside package directory and converted it to typescript and now I'm using it in my project. |
|
I fixed an error on |
|
@danielart the PR is finnaly ready for review. |
| @@ -25,6 +25,7 @@ module.exports = { | |||
| 'rules': { | |||
| 'require-jsdoc': 0, | |||
| 'react/prop-types': 0, | |||
| 'prefer-const': 0, | |||
There was a problem hiding this comment.
@danielart I have seen that Preact in their projects always use let, this makes the final bundle smaller. I have tried it and it does, it reduces the size a little bit.
Work:
getStorehelperwithStoreHoCcreateStoreBREAKING CHANGE.useStoreandwithStoreStorecomponent (now withgetStoreand callback change it no longer makes sense) BREAKING CHANGE.1.2kb1.08kb984b, should go down to less than 1kb