fix: unnecessary tool writes #1909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RutZap
reviewed
May 26, 2025
davenewza
commented
May 27, 2025
| @@ -408,7 +408,7 @@ message CursorPaginationConfig { | |||
| message PageSizeConfig { | |||
| string request_input = 1; | |||
| JsonPath response_field = 2; | |||
| int32 default_value = 3; | |||
| optional int32 default_value = 3; | |||
There was a problem hiding this comment.
This should be optional right?
RutZap
reviewed
May 27, 2025
Comment on lines
+542
to
+545
| if old != nil && new == nil { | ||
| return new | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| if old != nil && new == nil { | |
| return new | |
| } |
This is redundant as we'd end up returning new anyways
RutZap
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not write the the user tool configs unless there has actually been a change. We want to keep the config changes to an absolutely minimal.