8000 Use more common units and names for expressing file size by ankon · Pull Request #205 · tchiotludo/akhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use more common units and names for expressing file size #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

ankon
Copy link
Contributor
@ankon ankon commented Jan 31, 2020
  • Use 'Size' instead of 'Weight' in the topic list UI, and rename the existing column to 'Count'
  • Use SI binary units (B, Kibibyte, Mebibyte, ...) instead of the 1000/octet-based numbers

Expressing a file "weight" in "octets" is quite common in the French locale, but this is rather confusing for English -- where it is a file "size" in "bytes". This commit tries to change to the binary SI units as per https://en.wikipedia.org/wiki/Byte.

* Use 'Size' instead of 'Weight' in the topic list UI, and rename the existing column to 'Count'
* Use SI binary units (B, Kibibyte, Mebibyte, ...) instead of the 1000/octet-based numbers
@tchiotludo
Copy link
Owner

agree with that :)
Maybe my french origin allow me to talk Franglais

@tchiotludo tchiotludo merged commit 612cd18 into tchiotludo:dev Jan 31, 2020
@ankon ankon deleted the pr/si-units branch January 31, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0