Tags: tc-dc/cockroach
Tags
ui: databases page requires click to load table info Currently, the databases page automatically loads stats and info on all tables in all database simultaneously. This can cause heavy load and contention on clusters with hundreds of tables and/or databases. This change introduces a quick fix to prevent the immediate problem with the expectation that we will revisit the databases page for a more thorough redesign in the near future. This change adds a button next to each database in the databases page titled "Load stats for all tables" which triggers the queries to load table-specific stats for just that one database. The tables will be loaded in sequence by converting the loading loop to use async/await to ensure one query is executed at a time. One problem this introduces is that the database stats summary box on the right computes its data incrementally and will show changing data as more tables load for a specific database. We have chosen to not show the updated data until all table info has been loaded for the given database. Release note (admin ui change): Loading table-level stats requires a button click per-database in order to prevent contention for clusters with many databases and/or tables. In addition, the loading of table data is staggered by table instead of triggered simultaneously for all tables.
Merge pull request cockroachdb#56117 from solongordon/backport20.2-54712 release-20.2: sql: schemas only inherit valid privileges from db
Merge pull request cockroachdb#55781 from lucy-zhang/backport20.2-55779 release-20.2: sql: disallow moving tables with user-defined types into a different DB
backupccl: change CPUT semantics when publishing restored tables Previously we asserted that the descriptors that we're publishing PUBLIC have not changed since they were added in the OFFLINE state. There are cases where this assertion is failing. This is not ideal since we perform this check at the end of what could be a potentially lengthy restore. This assertion is enforced via a CPut and so to prevent these last stage failures we now resort to first reading the KV stored table desc, mutating its state and then writing it back to KV. To further collect information on what is changing the desc while it is in an offline state, logging has been added. Informs: cockroachdb#55690 Release note: None
Merge pull request cockroachdb#55621 from rafiss/backport20.1-54080 release-20.1: sql/pgwire: min/max use correct type in planning
Merge pull request cockroachdb#55522 from rafiss/backport20.2-55472 release-20.2: sql: remove virtual index on information_schema.tables(table_name)
Merge pull request cockroachdb#55305 from solongordon/backport20.2-55292 release-20.2: sql: do not inherit role options
Merge pull request cockroachdb#55168 from asubiotto/fix-54837 release-20.1: colexec: add mutex to colBatchScan
Merge pull request cockroachdb#54977 from rytaft/backport19.2-54950 release-19.2: build: reduce verbosity and bump timeout for SQL Race Logic Test
sql: add memory accounting for fetches This commit adds a memory monitor to the kv fetcher infrastructure that's initialized by its users. When kv fetches occur, the new infrastructure ensure that there's always at least 1 kilobyte allocated for the fetch before it happens. Once the fetch returns, the accounting is adjusted to include the entire size of the fetch. Subsequent fetches that return less memory do *not* ratchet down the allocation size to preserve safety and reduce some pointless allocation adjustment churning. This memory monitoring is gated behind a new cluster setting called `sql.scan_memory_accounting.enabled` in 20.1. In 20.2, this memory monitoring will always be on, and no such cluster setting will exist. Release note (sql change): the memory used by disk scans is accounted for, reducing the likelihood of out of memory conditions that result in process crashes as opposed to SQL out of memory error messages. This new behavior is off by default, and is gated behind the sql.scan_memory_accounting.enabled cluster setting. Release justification: fixes for high-priority bugs in existing functionality
PreviousNext