fix: reset num_pe_exports on export dir parsing #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks good to me - I haven't done much testing with multiple dlls, please let me know about problems. |
|
Yep, this patch is not entirely valid, as pe_exports shouldn't be reallocated on every dll load, but instead store exports from every dll, as it used in search Currently i need this project to load windows-only library in linux process ValveSoftware/SteamVR-for-Linux#450 (comment) And i will try to fix this and issues with loading multiple dlls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting segfault here while loading multiple dlls, as num_pe_exports was exceeding pe_exports size on some point