8000 `space/index:bsize()` have different return value type · Issue #9735 · tarantool/tarantool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

space/index:bsize() have different return value type #9735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
d-enk opened this issue Feb 27, 2024 · 0 comments · Fixed by #10706
Closed

space/index:bsize() have different return value type #9735

d-enk opened this issue Feb 27, 2024 · 0 comments · Fixed by #10706
Assignees
@Gumix
Labels
3.2 Target is 3.2 and all newer release/master branches bug Something isn't working

Comments

@d-enk
Copy link
d-enk commented Feb 27, 2024

type(box.space.SPACE:bsize()) -- cdata
type(box.space.SPACE.index[0]:bsize()) -- number

tarantool/src/box/lua/schema.lua

Lines 1999 to 2005 in 31c2ddb

base_index_mt.bsize = function(index)
check_index_arg(index, 'bsize')
local ret = builtin.box_index_bsize(index.space_id, index.id)
if ret == -1 then
box.error()
end
return tonumber(ret)

Looks like space:bsize() also needs to be converted to number
@d-enk d-enk added the bug Something isn't working label Feb 27, 2024
@Gumix Gumix added 2.11 Target is 2.11 and all newer release/master branches 3.2 Target is 3.2 and all newer release/master branches and removed 2.11 Target is 2.11 and all newer release/master branches labels Oct 16, 2024
Gumix added a commit to Gumix/tarantool that referenced this issue Oct 16, 2024
@Gumix
box/lua: change space:bsize() return type from cdata to number
b53f955 
To be consistent with other similar methods, e.g. `index:bsize()`.

Closes tarantool#9735

NO_DOC=bugfix
NO_CHANGELOG=minor
@Gumix Gumix mentioned this issue Oct 16, 2024
Merged
Gumix added a commit to Gumix/tarantool that referenced this issue Oct 17, 2024
@Gumix
box/lua: change space:bsize() return type from cdata to number
00c14f8 
To be consistent with other similar methods, e.g. `index:bsize()`.

Closes tarantool#9735

NO_DOC=bugfix
@locker locker closed this as completed in c10c629 Oct 18, 2024
locker pushed a commit that referenced this issue Oct 18, 2024
@Gumix @locker
box/lua: change space:bsize() return type from cdata to number
b6615cb 
To be consistent with other similar methods, e.g. `index:bsize()`.

Closes #9735

NO_DOC=bugfix

(cherry picked from commit c10c629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gumix Gumix

Labels
3.2 Target is 3.2 and all newer release/master branches bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

box/lua: change space:bsize() return type from cdata to number Gumix/tarantool
2 participants
@Gumix @d-enk
0