feat: add nats hord driver support #27
Annotations
1 error
commitlint
You have commit messages with errors
⧗ input: feat: Add NATS Hord driver support
This commit introduces support for using NATS as a key-value store
via the Hord library.
NATS configuration and testing align with established patterns within
the Tarmac project. The NATS test case in TestFullService is treated
consistently with other integration tests. Unnecessary inline comments
added during development have been removed.
Changes include:
- NATS configuration parameters are fetched directly (e.g., `nats_urls`)
in `pkg/app/app.go`.
- The `pkg/config/config.go` file no longer contains NATS-specific
structures.
- Documentation in `docs/running-tarmac/configuration.md` has been
updated for the corrected configuration keys.
- NATS testing is integrated into the `TestFullService` function in
`pkg/app/server_test.go`.
- The import alias for the NATS hord driver is now `nats`.
- Unnecessary inline comments related to NATS have been removed from
`pkg/app/app.go`, `pkg/app/app_test.go`, and
`pkg/app/server_test.go`.
- The CI configuration in `.github/workflows/build.yml` includes a
job for NATS tests, running a NATS server.
✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
⧗ input: Potential fix for code scanning alert no. 65: Workflow does not contain permissions
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
✖ subject may not be empty [subject-empty]
✖ type may not be empty [type-empty]
✖ found 2 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
⧗ input: feat: Add NATS Hord driver and align test infrastructure
This commit introduces support for using NATS as a key-value store
via the Hord library.
NATS configuration and testing align with established patterns within
the Tarmac project. Integration tests for NATS are managed via
Docker Compose, consistent with other services. The explicit sleep
in the Makefile for NATS tests has been removed.
Key changes include:
- NATS configuration parameters are fetched directly (e.g., `nats_urls`)
in `pkg/app/app.go`.
- `pkg/config/config.go` no longer contains NATS-specific structures.
- Documentation in `docs/running-tarmac/configuration.md` updated.
- NATS testing integrated into `TestFullService` in
`pkg/app/server_test.go`.
- Import alias for NATS hord driver is now `nats`.
- Unnecessary inline comments removed from relevant Go files.
- NATS service added to `dev-compose.yml`.
- `tests-nats` Makefile target updated to use Docker Compose for starting
NATS and running tests via a dedicated test runner service; explicit
sleep removed.
- NATS service definition removed from `.github/workflows/build.yml`;
CI now relies on the `make tests-nats` target.
- `go.mod` and `go.sum` files are up to date.
✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
|