8000 golink: revert Sec-Fetch-Site xsrftoken replacement by patrickod · Pull Request #184 · tailscale/golink · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

golink: revert Sec-Fetch-Site xsrftoken replacement #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

golink: revert Sec-Fetch-Site xsrftoken replacement #184

merged 1 commit into from
May 1, 2025

Conversation

patrickod
Copy link
Contributor
@patrickod patrickod commented May 1, 2025 •
edited
Loading

Unfortunately Sec-Fetch-Site headers are not sent over plaintext HTTP
making this unsuitable for non-TLS deployments.

Reverts c89d350
Reverts 7646755
Reverts a1ce1eb

Updates #160
Updates #156
Updates #130

@patrickod patrickod requested a review from willnorris May 1, 2025 17:54
@willnorris
Copy link
Member

did you not actually use git revert? I suppose there were multiple commits to revert? If so, could you go ahead and reference them directly so we have the connection?

@willnorris
Copy link
Member

Probably also reference all of the same issues as the original PR so that they're linked and we can then go back and reopen them

@patrickod
Copy link
Contributor Author

@willnorris I used revert on the three individually but rebase/squashed to one. I'll edit the msg to have their SHAs.

@patrickod patrickod force-pushed the patrickod/revert-sec-fetch-site branch from 3c5222f to eff01d0 Compare May 1, 2025 18:02
@patrickod
golink: revert Sec-Fetch-Site xsrftoken replacement
b37020d 
Unfortunately Sec-Fetch-Site headers are not sent over plaintext HTTP
making this unsuitable for non-TLS deployments.

Reverts c89d350
Reverts 7646755
Reverts a1ce1eb

Updates #160
Updates #156
Updates #130

Signed-off-by: Patrick O'Doherty <patrick@tailscale.com>
@patrickod patrickod force-pushed the patrickod/revert-sec-fetch-site branch from eff01d0 to b37020d Compare May 1, 2025 18:02
@willnorris willnorris mentioned this pull request May 1, 2025
Closed
@patrickod patrickod merged commit 3e2c22d into main May 1, 2025
4 checks passed
@patrickod patrickod deleted the patrickod/revert-sec-fetch-site branch May 1, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willnorris willnorris willnorris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickod @willnorris
0