Use empty files for record task #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
243238e to
455f6e6
Compare
lukas-mercari
approved these changes
May 28, 2024
There was a problem hiding this comment.
I think the integration tests are sufficient to prove that it works, but I doubled checked locally and it seems to work well! 👍
Thanks a lot, this is indeed cleaner than my attempt in #386!
| test.inputs.files(outputDir.map { | ||
| if (!it.asFile.exists()) { | ||
| it.asFile.mkdirs() | ||
| test.inputs.files( |
There was a problem hiding this comment.
I didn't know we can pass a Provider to files! (In fact, this is roughly what I was trying to do originally, but instead I was calling isRecordRun.get() which fails.) 👍
chrisbanes
referenced
this pull request
in chrisbanes/haze
May 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi) | `1.19.0` -> `1.20.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi) | `1.19.0` -> `1.20.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi-compose-desktop](https://togithub.com/takahirom/roborazzi) | `1.19.0` -> `1.20.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi-compose](https://togithub.com/takahirom/roborazzi) | `1.19.0` -> `1.20.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | `1.19.0` -> `1.20.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary> ### [`v1.20.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.20.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.19.0...1.20.0) ##### Workflow Enhancement We use images as inputs for tests, ensuring that the compare and verify tasks function correctly. However, while running record tasks, we do not need the input images. Despite this, these input images invalidate the record task and disable the cache. Therefore, we no longer use input images for record tasks. Thank you, [@​lukas-mercari](https://togithub.com/lukas-mercari), for informing us and proposing this improvement. ##### What's Changed - Use empty files for record task by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/389](https://togithub.com/takahirom/roborazzi/pull/389) - Fix condition of using output dir by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/390](https://togithub.com/takahirom/roborazzi/pull/390) **Full Changelog**: takahirom/roborazzi@1.19.0...1.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/chrisbanes/haze). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot
referenced
this pull request
in slackhq/circuit
May 29, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi) | plugin | minor | `1.18.0` -> `1.20.0` | | [io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.18.0` -> `1.20.0` | | [io.github.takahirom.roborazzi:roborazzi-compose](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.18.0` -> `1.20.0` | | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.18.0` -> `1.20.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary> ### [`v1.20.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.20.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.19.0...1.20.0) ##### Workflow Enhancement We use images as inputs for tests, ensuring that the compare and verify tasks function correctly. However, while running record tasks, we do not need the input images. Despite this, these input images invalidate the record task and disable the cache. Therefore, we no longer use input images for record tasks. Thank you, [@​lukas-mercari](https://togithub.com/lukas-mercari), for informing us and proposing this improvement. ##### What's Changed - Use empty files for record task by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/389](https://togithub.com/takahirom/roborazzi/pull/389) - Fix condition of using output dir by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/390](https://togithub.com/takahirom/roborazzi/pull/390) **Full Changelog**: takahirom/roborazzi@1.19.0...1.20.0 ### [`v1.19.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.19.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.18.0...1.19.0) ##### Bug Fix I was informed that if you have multiple test suites, the RoborazziPlugin sometimes fails due to concurrent processes. This happens because the cleanup process runs multiple times. Therefore, I made the cleanup process run only once. Thank you for reporting this, [@​lukas-mercari](https://togithub.com/lukas-mercari). ##### What's Changed - Remove unused dependency androidx.compose.ui:ui-graphics by [@​takahirom](https://togithub.com/takahirom) [https://github.com/takahirom/roborazzi/pull/373](https://togithub.com/takahirom/roborazzi/pull/373) - Fix issue where afterSuite runs for non-root suites by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/385](https://togithub.com/takahirom/roborazzi/pull/385) **Full Changelog**: takahirom/roborazzi@1.18.0...1.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM4MS43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The challenges we aim to address
#386