8000 Update faraday adapter to support Faraday 2.0 · Issue #686 · typhoeus/typhoeus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update faraday adapter to support Faraday 2.0 #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iMacTia opened this issue Nov 2, 2021 · 6 comments
8000
Open

Update faraday adapter to support Faraday 2.0 #686

iMacTia opened this issue Nov 2, 2021 · 6 comments

Comments

@iMacTia
Copy link
Contributor
iMacTia commented Nov 2, 2021

Hello there,

I'm Matt from the faraday core team, and I bring some exciting news 🎉 !
We're closing in on releasing Faraday 2.0 and with this release, we've made big changes on the way we manage adapters.
The biggest of these is that now adapters are not bundled anymore, and are instead shipped into their own, separate gems!
No more dependencies mess, no more 1st class and 2nd class adapters, power to the community 💪

What does this mean for Typhoeus?
Although these will be little, some changes to the current Typhoeus adapter will be required in order to support Faraday 2.0. You're free to keep it inside this repository, if you like, but our suggestion would be to move it into a separate one. We've created a handy template repo to make that process really easy, and we're available if you need any help!
You can see an example of this with the faraday-net_http adapter.

We'd love to keep Typhoeus in the faraday family, even after v2.0 is finally released, so please feel free to reach out if you need any help or guidance with this!
@Kjarrigan
Copy link
Member

@i0rek what do you think about a separate gem/project?

@hanshasselberg
Copy link
Member

If the recommendation is to create a separate gem, I am up for it.

@hanshasselberg
Copy link
Member

I created https://github.com/typhoeus/faraday-typhoeus.

@iMacTia
Copy link
Contributor Author
iMacTia commented Nov 8, 2021

Thanks @Kjarrigan @i0rek, great to see things moving!
I'm sure you guys can handle but as I said, feel free to reach out if you need any help.

Also feel free to close this issue if you want to, now that you've decided on how to proceed 👍

@jmortlock jmortlock mentioned this issue Jan 11, 2022
Merged
@andrehjr andrehjr mentioned this issue Jan 11, 2022
Open
@iMacTia
Copy link
Contributor Author
iMacTia commented Jan 14, 2022

Hi @Kjarrigan @i0rek, just a quick nudge to let you know that Faraday 2.0 has shipped.
I want to renew my invitation to reach out if you need any help with https://github.com/typhoeus/faraday-typhoeus

@ylecuyer ylecuyer mentioned this issue Jan 25, 2022
Merged
@casperisfine casperisfine mentioned this issue Feb 18, 2022
Merged
ryanwi added a commit to ryanwi/hiringtrends that referenced this issue Mar 20, 2022
@ryanwi
stick with faraday 1
846f2d7 
typhoeus support for faraday 2 not ready yet

typhoeus/typhoeus#686
@nickcampbell18 nickcampbell18 mentioned this issue Mar 29, 2022
Closed
1 task
@dleavitt
Copy link

@iMacTia I've got a decent pass here:

@tagliala tagliala mentioned this issue Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
< 3E0B /div>
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hanshasselberg @dleavitt @Kjarrigan @iMacTia
0