Support scala 3 #290
Merged
Support scala 3 #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
Closed
johnynek
reviewed
Aug 30, 2021
build.sbt
Outdated
| libraryDependencies ++= Seq( | ||
| "org.typelevel" %%% "cats-core" % "2.6.1", | ||
| "org.typelevel" %%% "cats-core" % "2.6.1", | ||
| "org.typelevel" %%% "cats-testkit-scalatest" % "2.1.5", |
djspiewak
requested changes
Aug 30, 2021
build.sbt
Outdated
| addCompilerPlugin("org.typelevel" % "kind-projector" % "0.13.1" cross CrossVersion.full), | ||
| addCompilerPlugin("com.olegpy" %% "better-monadic-for" % "0.3.1"), | ||
| scalaVersion := "3.0.1", | ||
| crossScalaVersions := Seq(scalaVersion.value, "2.12.13", "2.13.6"), |
There was a problem hiding this comment.
This is very dangerous and you shouldn't use this construction. I realize it's very common in a lot of Scala builds but we need to weed it out because it leads to insanity. Remember that scalaVersion is changed by any ++ or + usage, meaning that the value of crossScalaVersions will depend on the current Scala version, which is not at all what y
8000
ou want.
Suggested change
| crossScalaVersions := Seq(scalaVersion.value, "2.12.13", "2.13.6"), | |
| crossScalaVersions := Seq("3.0.1", "2.12.13", "2.13.6"), | |
| scalaVersion := crossScalaVersions.value.last, |
The above accomplishes the same thing without the associated problems.
project/plugins.sbt
Outdated
| @@ -6,6 +6,7 @@ addSbtPlugin("com.geirsson" % "sbt-ci-release" % "1.5.7") | |||
| addSbtPlugin("io.chrisdavenport" % "sbt-mima-version-check" % "0.1.2") | |||
| addSbtPlugin("io.chrisdavenport" % "sbt-no-publish" % "0.1.0") | |||
| addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.4.3") | |||
| addSbtPlugin("com.timushev.sbt" % "sbt-updates" % "0.6.0") | |||
There was a problem hiding this comment.
Is this needed? Particularly with scala-steward?
Signed-off-by: Carlos Quiroz <3615303+cquiroz@users.noreply.github.com>
|
@djspiewak @johnynek Thanks for the comments. I fixed what you suggested |
johnynek
approved these changes
Aug 30, 2021
djspiewak
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not many code changes are needed, it is mostly lib updates and type declarations
Fixes #289