-
Notifications
You must be signed in to change notification settings - Fork 373
Added confidential checker #6981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ed references in code as necessary
…caped SQL values as SqlSanitized.
SQL tainting qualifiers and basic tests
…and SqlSanitizedUser
…bined SqlQuoteless and SqlEvenQuotes; revised documentations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just a couple last comments.
* Enforces Confidential String concatenation rules: | ||
* | ||
* <ul> | ||
* <li>(Confidential + NonConfidential) returns Confidential (commutatively); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same comment text as in the TreeAnnotator. Can you please document the relationship between the two? What does each one do, and why are both necessary?
* @param leftOperand the left operand to be concatenated | ||
* @param rightOperand the right operand to be concatenated | ||
* @param p the input abstract values | ||
* @return the resulting AnnotationMirror of the string concatenation operation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method may also return null
. Please document the conditions under which that happens.
Associated with JDK pull request #224