8000 feat(core): implement `getHighestSnapshotSlot` RPC endpoint by Ozodimgba · Pull Request #149 · txtx/surfpool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(core): implement getHighestSnapshotSlot RPC endpoint #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2025
Merged

feat(core): implement getHighestSnapshotSlot RPC endpoint #149

merged 4 commits into from
Jun 12, 2025

Conversation

Ozodimgba
Copy link
Contributor

@MicaiahReid surfpool doesn't implement incremental snapshots?

MicaiahReid
MicaiahReid requested changes Jun 9, 2025
View reviewed changes
Copy link
Member
@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently don't have any concept of snapshots, and I'm not sure if we'll need it or now. It looks like if a node doesn't have a snapshot, it should return

{
  "jsonrpc": "2.0",
  "error": {
    "code": -32008,
    "message": "No snapshot"
  },
  "id": 1
}

based off these docs: https://solana.com/docs/rpc/http/gethighestsnapshotslot

Can we go with this?

@MicaiahReid MicaiahReid changed the title added getHighestSnapshotSlot with tests feat(core): implement getHighestSnapshotSlot RPC endpoint Jun 9, 2025
@Ozodimgba
Copy link
Contributor Author

We currently don't have any concept of snapshots, and I'm not sure if we'll need it or now. It looks like if a node doesn't have a snapshot, it should return

{
  "jsonrpc": "2.0",
  "error": {
    "code": -32008,
    "message": "No snapshot"
  },
  "id": 1
}

based off these docs: https://solana.com/docs/rpc/http/gethighestsnapshotslot

Can we go with this?

sure will do

@Ozodimgba Ozodimgba requested a review from MicaiahReid June 12, 2025 19:02
@MicaiahReid
Copy link
Member

Ah @Ozodimgba, just needs cargo +nightly fmt --all -- --check

@MicaiahReid MicaiahReid merged commit fe7f767 into txtx:main Jun 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgalabru lgalabru lgalabru approved these changes

@MicaiahReid MicaiahReid MicaiahReid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ozodimgba @MicaiahReid @lgalabru
0