feat(core): implement getBlockHeight RPC method
#132
Conversation
crates/core/src/rpc/minimal.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn test_get_block_height_debug_slots() { |
There was a problem hiding this comment.
This test has no assertions, and I'm not sure from the name what the purpose of the test is
There was a problem hiding this comment.
I think that was my personal test that I didnt remove
crates/core/src/rpc/minimal.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn test_get_block_height_with_valid_min_context_slot() { |
There was a problem hiding this comment.
Good test! Can we also get one for the failure case - asserting the RPC returns an error if the min_context_slot is beyond the current slot?
|
@MicaiahReid refactored blocks, take a look |
|
@MicaiahReid this should do it |
|
aggh, sorry, looks like CI isn't passing cause of some formatting. Should be an easy fix! Run |
|
@MicaiahReid done |
|
Hey @Ozodimgba there are still more issues that need to be fixed from |
getBlockHeight RPC method
No description provided.