8000 custom socket-like file descriptors by gkgoat1 · Pull Request #111 · turbolent/w2c2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

custom socket-like file descriptors #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gkgoat1
Copy link
@gkgoat1 gkgoat1 commented Feb 6, 2025

This adds custom socket-like FDs to w2c2, which is useful for virtualization.

This code has been reformatted, but there was no clang-format file. In addition, I do not know if the code is still C89; Please comment if any of those issues come up.

@turbolent
Copy link
Owner

@gkgoat1 Thank you for this contribution! I like this idea 👍

The PR is currently really hard to review, because it's almost impossible to see what was actually changed. Could you please avoid /revert the irrelevant re-formatting?

@gkgoat1
Copy link
Author
gkgoat1 commented Feb 9, 2025

@gkgoat1 Thank you for this contribution! I like this idea 👍

The PR is currently really hard to review, because it's almost impossible to see what was actually changed. Could you please avoid /revert the irrelevant re-formatting?

Do you have a .clang-format file or similar I can use to restore the formatting?

@turbolent
Copy link
Owner

@gkgoat1 No, I don't use clang format, it might be worth investigating.

Thank you for removing the re-formatting, it's now clear what you're trying to add. I'll open a follow up PR to improve the API a bit and address some of the problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0