More kind #79
Merged
More kind #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added parseMoreChildren function and updated related parsing functions
Added a More field to Comment and Post so parsing makes sense. Fixed parsing functions. Added tests.
|
|
|
Thank you 8000 for submitting a pull request! I think this is a good addition. My only reservation is about the changes to the module files. I am not sure why these are necessary for this change. If those changes should be made, would you mind moving them to a separate request? |
|
Nope I didnt need those changes. That was the IDE doing its thing. They have been removed. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #78
Adds support for the more type. Comment and Post types can now be populated with a More if a more type thing was one of their children. Additionally, a function to parse calls to /api/morechildren was added.