8000 Duckdb: Support double equals comparison by keraion · Pull Request #6924 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Duckdb: Support double equals comparison #6924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Duckdb: Support double equals comparison #6924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/sqlfluff/dialects/dialect_duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
BinaryOperatorSegment,
Bracketed,
CodeSegment,
ComparisonOperatorSegment,
Dedent,
Delimited,
IdentifierSegment,
Expand Down Expand Up @@ -74,6 +75,7 @@
duckdb_dialect.add(
LambdaArrowSegment=StringParser("->", SymbolSegment, type="lambda_arrow"),
OrIgnoreGrammar=Sequence("OR", "IGNORE"),
EqualsSegment_a=StringParser("==", ComparisonOperatorSegment),
)

duckdb_dialect.replace(
Expand Down Expand Up @@ -142,6 +144,13 @@
"single_quote", IdentifierSegment, type="quoted_identifier", casefold=str.lower
),
ListComprehensionGrammar=Ref("ListComprehensionExpressionSegment"),
ComparisonOperatorGrammar=ansi_dialect.get_grammar(
"ComparisonOperatorGrammar"
).copy(
insert=[
Ref("EqualsSegment_a"),
]
),
)

duckdb_dialect.insert_lexer_matchers(
Expand Down Expand Up @@ -173,6 +182,7 @@
"escape_replacements": [(r'""', '"')],
},
),
RegexLexer("equals", r"==?", CodeSegment),
]
)

Expand Down
7 changes: 7 additions & 0 deletions test/fixtures/dialects/duckdb/double_equal.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
SELECT
COALESCE(
MAX(CASE WHEN col1 == 'A' THEN cola END),
MAX(CASE WHEN col1 == 'B' THEN colb END),
MAX(CASE WHEN col1 = 'C' THEN colb END)
) AS result
FROM my_table;
102 changes: 102 additions & 0 deletions test/fixtures/dialects/duckdb/double_equal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
# YML test files are auto-generated from SQL files and should not be edited by
# hand. To help enforce this, the "hash" field in the file must match a hash
# computed by SQLFluff when running the tests. Please run
# `python test/generate_parse_fixture_yml.py` to generate them after adding or
# altering SQL files.
_hash: 8f84857317f2db485136f25707f1a315933c79426a5b55ed8d253d5370903bfd
file:
statement:
select_statement:
select_clause:
keyword: SELECT
select_clause_element:
function:
function_name:
function_name_identifier: COALESCE
function_contents:
bracketed:
- start_bracket: (
- expression:
function:
function_name:
function_name_identifier: MAX
function_contents:
bracketed:
start_bracket: (
expression:
case_expression:
- keyword: CASE
- when_clause:
- keyword: WHEN
- expression:
column_reference:
naked_identifier: col1
comparison_operator: ==
quoted_literal: "'A'"
- keyword: THEN
- expression:
column_reference:
naked_identifier: cola
- keyword: END
end_bracket: )
- comma: ','
- expression:
function:
function_name:
function_name_identifier: MAX
function_contents:
bracketed:
start_bracket: (
expression:
case_expression:
- keyword: CASE
- when_clause:
- keyword: WHEN
- expression:
column_reference:
naked_identifier: col1
comparison_operator: ==
quoted_literal: "'B'"
- keyword: THEN
- expression:
column_reference:
naked_identifier: colb
- keyword: END
end_bracket: )
- comma: ','
- expression:
function:
function_name:
function_name_identifier: MAX
function_contents:
bracketed:
start_bracket: (
expression:
case_expression:
- keyword: CASE
- when_clause:
- keyword: WHEN
- expression:
column_reference:
naked_identifier: col1
comparison_operator:
raw_comparison_operator: '='
quoted_literal: "'C'"
- keyword: THEN
- expression:
column_reference:
naked_identifier: colb
- keyword: END
end_bracket: )
- end_bracket: )
alias_expression:
keyword: AS
naked_identifier: result
from_clause:
keyword: FROM
from_expression:
from_expression_element:
table_expression:
table_reference:
naked_identifier: my_table
statement_terminator: ;
0