8000 Improves support for `SET` statements in MySQL. by joaostorrer · Pull Request #6922 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improves support for SET statements in MySQL. #6922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2025
Merged

Improves support for SET statements in MySQL. #6922

merged 3 commits into from
Jun 3, 2025

Conversation

joaostorrer
Copy link
Contributor

Closes #6906

Also I grouped tests for SET statement in only one set.sql file.

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 3, 2025

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19693      0   100%

249 files skipped due to complete coverage.

WittierDinosaur
WittierDinosaur approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor
@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Jun 3, 2025
Merged via the queue into sqlfluff:main with commit f628d1b Jun 3, 2025
28 checks passed
@joaostorrer joaostorrer deleted the mysql_set branch June 4, 2025 17:53
thomascjohnson pushed a commit to thomascjohnson/sqlfluff that referenced this pull request Jun 17, 2025
@joaostorrer @thomascjohnson
Improves support for SET statements in MySQL. (sqlfluff#6922)
9aef77b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mysql SET global and session not supported
2 participants
@joaostorrer @WittierDinosaur
0