feat(snowflake): add support for 'DROP ICEBERG TABLE' statement #6860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new segment `DropIcebergTableStatementSegment` in the Snowflake dialect to support parsing of `DROP ICEBERG TABLE [IF EXISTS] <table_name>` syntax.
Changes made:
- Defined `DropIcebergTableStatementSegment` with appropriate `match_grammar` using `Sequence`, `Ref`, and `IfExistsGrammar`.
- Registered the new segment via `snowflake_dialect.add(...)`.
This change resolves issues with SQLFluff failing to parse valid Snowflake statements involving Iceberg tables, such as:
DROP ICEBERG TABLE IF EXISTS SAMPLE_DEV.SAMPLE.CASH;
Helps avoid parse errors like:
PRS | Found unparsable section: 'DROP ICEBERG TABLE IF EXISTS ...'
Coverage Results ✅ |
auto-merge was automatically disabled
May 3, 2025 14:31
Head branch was pushed to by a user without write access
|
Hi @WittierDinosaur can you approve the pr again as some test fails which required rerun now after new commits |
Added a parser test case for the new DROP ICEBERG TABLE syntax in the Snowflake dialect. This file includes example SQL statements to validate that the dialect correctly parses the new segment implemented in `dialect_snowflake.py`. The corresponding YAML file will be generated using `tox -e generate-fixture-yml`.
|
Somehow you've got rid of the yml. Run |
Generated .yml file from .sql file using python test/generate_parse_fixture_yml.py -d snowflake
No Danny , The .yml file isn't auto generated due to which some test cases failed , so again it requires the approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new segment
DropIcebergTableStatementSegmentin the Snowflake dialect to support parsing ofDROP ICEBERG TABLE [IF EXISTS] <table_name>syntax.fixes #6859
Changes made:
DropIcebergTableStatementSegmentwith appropriatematch_grammarusingSequence,Ref, andIfExistsGrammar.snowflake_dialect.add(...).This change resolves issues with SQLFluff failing to parse valid Snowflake statements involving Iceberg tables, such as:
Helps avoid parse errors like:
PRS | Found unparsable section: 'DROP ICEBERG TABLE IF EXISTS ...'
Brief summary of the change made
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.