8000 SparkSQL: Make colon optional in `STRUCT` datatype by NormallyGaussian · Pull Request #6739 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SparkSQL: Make colon optional in STRUCT datatype #6739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2025
Merged

SparkSQL: Make colon optional in STRUCT datatype #6739

merged 1 commit into from
Mar 22, 2025

Conversation

NormallyGaussian
Copy link
Contributor

Brief summary of the change made

Fixes #6699. The colon is optional in Spark SQL. See https://docs.databricks.com/aws/en/sql/language-manual/data-types/struct-type.

In addition to the Databricks documentation, I've also confirmed in vanilla Spark SQL that these create table statements are valid.

I wasn't able to confirm whether this is true for Hive, so I've copied over the Hive implementation and changed the colon to optional.

Are there any other side effects of this change that we should be aware of?

N/A

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19345      0   100%

248 files skipped due to complete coverage.

WittierDinosaur
WittierDinosaur approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor
@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Mar 22, 2025
Merged via the queue into sqlfluff:main with commit 1ca5ed3 Mar 22, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Struct in Databricks parsing error
2 participants
@NormallyGaussian @WittierDinosaur
0