8000 Allow double equals in hive dialect by TheCleric · Pull Request #6623 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow double equals in hive dialect #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2025
Merged

Allow double equals in hive dialect #6623

merged 3 commits into from
Feb 3, 2025

Conversation

TheCleric
Copy link
Contributor

Brief summary of the change made

Allows the use of a == in the hive sql dialect as a synonym of = per https://cwiki.apache.org/confluence/display/Hive/Hive+Operators

fixes #6622

Are there any other side effects of this change that we should be aware of?

None that I'm aware of

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 31, 2025 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19304      0   100%

248 files skipped due to complete coverage.

WittierDinosaur
WittierDinosaur reviewed Feb 1, 2025
View reviewed changes
test/fixtures/dialects/hive/double_equals.sql Outdated
FROM
t
WHERE
t.a = = t.b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case without the space? I just want to make sure this doesn't actually require a lexer change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced the spaced version as that one seemed odd (and was inadvertent). Let me know if you want both test cases.

WittierDinosaur
WittierDinosaur reviewed Feb 2, 2025
View reviewed changes
src/sqlfluff/dialects/dialect_hive.py Outdated

match_grammar: Matchable = OneOf(
Ref("RawEqualsSegment"),
Sequence(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified to a sequence with

Ref("RawEqualsSegment"),
Ref("RawEqualsSegment", optional=True),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

WittierDinosaur
WittierDinosaur approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor
@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Feb 3, 2025
Merged via the queue into sqlfluff:main with commit 17f560d Feb 3, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parser throws error on == operator
2 participants
@TheCleric @WittierDinosaur
0