8000 Add Implicit Indents to Qualify by WittierDinosaur · Pull Request #6438 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Implicit Indents to Qualify #6438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2024
Merged

Add Implicit Indents to Qualify #6438

merged 3 commits into from
Nov 21, 2024

Conversation

WittierDinosaur
Copy link
Contributor
@WittierDinosaur WittierDinosaur commented Nov 9, 2024 •
edited
Loading

Brief summary of the change made

Fixes #6325

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Nov 9, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18740      0   100%

241 files skipped due to complete coverage.

greg-finley
greg-finley approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor
@greg-finley greg-finley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any quick test we should add?

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit ed9d0c9 Nov 21, 2024
31 checks passed
@WittierDinosaur WittierDinosaur deleted the qualify-implicit-indent branch November 21, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-finley greg-finley greg-finley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow_implicit_indents doesn't support QUALIFY
2 participants
@WittierDinosaur @greg-finley
0