8000 Add "target_path" configuration to the dbt templater by wircho · Pull Request #6423 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add "target_path" configuration to the dbt templater #6423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 12, 2024
Merged

Add "target_path" configuration to the dbt templater #6423

merged 4 commits into from
Nov 12, 2024

Conversation

wircho
Copy link
Contributor
@wircho wircho commented Nov 1, 2024

Brief summary of the change made

Resolves #6405

This PR adds a new configuration option that goes under [sqlfluff:templater:dbt]; target_path which defines the path where dbt stores its artifacts.

Are there any other side effects of this change that we should be aware of?

None.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@wircho wircho force-pushed the dbt-target-path-config branch from 84140c4 to 16d7cba Compare November 1, 2024 23:34
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Nov 2, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18766      0   100%

243 files skipped due to complete coverage.

@wircho wircho force-pushed the dbt-target-path-config branch from 16d7cba to 611f1da Compare November 5, 2024 16:13
@wircho
Copy link
Contributor Author
wircho commented Nov 5, 2024

@WittierDinosaur, @greg-finley, I'd love to hear your opinion of this small improvement.

@greg-finley greg-finley added this pull request to the merge queue Nov 12, 2024
Merged via the queue into sqlfluff:main with commit 79b1683 Nov 12, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-finley greg-finley greg-finley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the dbt target path (not just the target) customizable under the dbt templater settings
3 participants
@wircho @greg-finley @WittierDinosaur
0