8000 Revise dbt warnings when a file fails to compile by alanmcruickshank · Pull Request #6338 · sqlfluff/sqlfluff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revise dbt warnings when a file fails to compile #6338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2024
Merged

Revise dbt warnings when a file fails to compile #6338

merged 2 commits into from
Oct 12, 2024

Conversation

alanmcruickshank
Copy link
Member

There's a section in the dbt template which was marked as # pragma: no cover, but I managed to cover it recently! This adds a test case which triggers it - and also removes the old warning asking people to report it, because I don't think they need to anymore.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Oct 11, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   18570      0   100%

236 files skipped due to complete coverage.

@greg-finley greg-finley added this pull request to the merge queue Oct 12, 2024
Merged via the queue into main with commit 37bffc3 Oct 12, 2024
30 checks passed
@greg-finley greg-finley deleted the ac/dbt_warnings branch October 12, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-finley greg-finley greg-finley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanmcruickshank @greg-finley
0